[7125] in linux-scsi channel archive

home help back first fref pref prev next nref lref last post

Re: aha2940 problem - more detail

daemon@ATHENA.MIT.EDU (Kurt Garloff)
Fri Sep 3 04:12:13 1999

Date:   Fri, 3 Sep 1999 09:36:09 +0200
From:   Kurt Garloff <garloff@suse.de>
To:     Doug Ledford <dledford@redhat.com>
Cc:     Linux-SCSI <linux-scsi@vger.rutgers.edu>
Mail-Followup-To: Doug Ledford <dledford@redhat.com>,
	Linux-SCSI <linux-scsi@vger.rutgers.edu>
In-Reply-To: <37CBA753.3004426C@redhat.com>; from Doug Ledford on Tue, Aug 31, 1999 at 05:58:43AM -0400


--mJm6k4Vb/yFcL9ZU
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable

On Tue, Aug 31, 1999 at 05:58:43AM -0400, Doug Ledford wrote:
> Let me demonstrate, by means of an actuall aic7xxx setup line I have put =
into
> my lilo.conf in the past, why interpreting commas in a string variable is
> wrong and how the suggestion you made would break my parser:
>=20
> append=3D"aic7xxx=3Dverbose:0x9939,tag_info:{,{32,32,32,32,32,32,32,32},{=
,,,,32,32,32,32,32,32},{0,0}},panic_on_abort"
>=20
> Now, if insmod wants to put those into individual strings then I have to =
turn
> around and cat them all back together and re-insert the commas in order to
> make my parser work.  In general, the format my parser uses allows a pers=
on to
> do set a lot of variables with a minumum of effort.  Far less effort than=
 the
> typical insmod way of doing things which would translate the above line t=
o:
>=20
> insmod aic7xxx aic7xxx_verbose=3D0x9939 aic7xxx_panic_on_abort=3D1
> aic7xxx_tag_info=3D255,255,255,255,255,255,255,255,255,255,255,255,255,25=
5,255,255,32,32,32,32,32,32,32,32,255,255,255,255,255,255,255,255,255,255,2=
55,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,32,3=
2,32,32,32,32,255,255,255,255,255,255,0,0

OK, the insmod parser should respect quotes and braces {}.

What about adding this functionality to=20
(a) the kernel
(b) insmod
and get rid of a lot of parsing stuff in the drivers?

I think Keith Owens (modutils maintainer) will agree with that; I don't know
about Linus.

Regards,
--=20
Kurt Garloff  <garloff@suse.de>                             Wuppertal, FRG
PGP2 key: See mail header, key servers            Linux kernel development
SuSE GmbH, N=FCrnberg, FRG               SCSI drivers: tmscsim(DC390), DC395

--mJm6k4Vb/yFcL9ZU
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: 2.6.3i

iQCVAwUBN896aRaQN/7O/JIVAQF0SgP+Lr7+b5FsHToo2t//w6nNowiwd3IG2v2r
zYlaRf6eFK1fMRfNVymgZXIwGuBpNDBbPepFJY3BTZDiwfuLE3g5CtoLZH1ivNDf
BPK7HhRKOcsZK53tbgycYHY4DiUQMnnOqglEFEUMZFlNRwb1Li5nriqlrWmqbbGv
dkI3C3/S6aw=
=iAzX
-----END PGP SIGNATURE-----

--mJm6k4Vb/yFcL9ZU--

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.rutgers.edu

home help back first fref pref prev next nref lref last post