[6996] in linux-scsi channel archive

home help back first fref pref prev next nref lref last post

signals handled by scsi error handler

daemon@ATHENA.MIT.EDU (Paul Gortmaker)
Mon Aug 16 13:51:32 1999

Date:   Sun, 15 Aug 1999 05:09:56 -0400
From: Paul Gortmaker <p_gortmaker@yahoo.com>
To: alan@lxorguk.ukuu.org.uk
CC: torvalds@transmeta.com, linux-scsi@vger.rutgers.edu


The scsi_eh thread responds to KILL INT and TERM so that the module can
be unloaded - however I cant see a reason why you would want it to
respond to any signals when it is built into the kernel.  Currently you
get a zombie thread if it is built in and receives such a signal. 

This trivial diff (2.2.x) seems like the right thing to do unless
I'm overlooking something. It solves the zombie problem anyways.
The code in 2.3.x looks unchanged so it probably needs it too.

Paul.


--- linux/drivers/scsi/scsi_error.c~	Mon Aug  9 03:46:28 1999
+++ linux/drivers/scsi/scsi_error.c	Sat Aug 14 05:55:19 1999
@@ -35,7 +35,11 @@
 #include "hosts.h"
 #include "constants.h"
 
-#define SHUTDOWN_SIGS	(sigmask(SIGKILL)|sigmask(SIGINT)|sigmask(SIGTERM))
+#ifdef MODULE
+	#define SHUTDOWN_SIGS	(sigmask(SIGKILL)|sigmask(SIGINT)|sigmask(SIGTERM))
+#else
+	#define SHUTDOWN_SIGS	(0UL)
+#endif
 
 #ifdef DEBUG
     #define SENSE_TIMEOUT SCSI_TIMEOUT




_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.rutgers.edu

home help back first fref pref prev next nref lref last post