[6750] in linux-scsi channel archive

home help back first fref pref prev next nref lref last post

Re: aha1542 "Wrong buffer length supplied" error

daemon@ATHENA.MIT.EDU (Guest section DW)
Fri Jun 25 14:10:55 1999

Date: 	Fri, 25 Jun 1999 19:33:05 +0200 (MET DST)
From: dwguest@win.tue.nl (Guest section DW)
To: linux-scsi@vger.rutgers.edu, simen-tt@online.no

Yes, this is one of the things my somewhat fixed aha1542.c avoids:

The official aha1542.c does

    if(*cmd == REQUEST_SENSE){
#ifndef DEBUG
      if (bufflen != sizeof(SCpnt->sense_buffer)) {
        printk("Wrong buffer length supplied for request sense (%d)\n",bufflen);
      };
#endif

My aha1542.c does

        if(*cmd == REQUEST_SENSE){
                /* Don't do the command - we have the sense data already */
#if 0
                /* scsi_request_sense() provides a buffer of size 256,
                   so there is no reason to expect equality */
                if (bufflen != sizeof(SCpnt->sense_buffer))
                        printk("aha1542: Wrong buffer length supplied "
                               "for request sense (%d)\n", bufflen);
#endif

Andries

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.rutgers.edu

home help back first fref pref prev next nref lref last post