[4282] in linux-scsi channel archive
Re: ncr53c8xx-3.0e ready for 2.2 [PATCH]
daemon@ATHENA.MIT.EDU (Gerard Roudier)
Fri Jul 3 17:48:53 1998
Date: Fri, 3 Jul 1998 22:48:33 +0200 (MET DST)
From: Gerard Roudier <groudier@club-internet.fr>
To: Kurt Garloff <garloff@kg1.ping.de>
cc: linux-scsi@vger.rutgers.edu
In-Reply-To: <19980702051223.A350@kg1.ping.de>
Hi Kurt,
On Thu, 2 Jul 1998, Kurt Garloff wrote:
> Hi Gerard,
>
> Great work!
Thanks.
> I wish the driver I'm working on (tmscsim/am53c974) would work that well.
A good driver for this chip in needed since this controller seems very
popular too.
> I found one minor problem, however:
> modprobe/insmod from modutils-2.1.85 don't want to accept parameters.
I have missed this stuff. Thanks for your fix.
"grep" said me that using "s" instead of "1s" is enough, so I have
incorporated your change and replaced "1s" by a single "s".
> Here's a patch:
>
> --- linux/drivers/scsi/ncr53c8xx.c.30e Thu Jul 2 05:05:33 1998
> +++ linux/drivers/scsi/ncr53c8xx.c Thu Jul 2 06:50:49 1998
> @@ -762,7 +762,10 @@
> driver_safe_setup __initdata = SCSI_NCR_DRIVER_SAFE_SETUP;
> #ifdef MODULE
> char *ncr53c8xx = 0; /* command line passed by insmod */
> -#endif
> +# if LINUX_VERSION_CODE >= LinuxVersionCode(2,1,30)
> +MODULE_PARM(ncr53c8xx, "1s");
> +# endif
> +# endif
> #endif
>
> /*
>
> I don't know, where exactly the MODULE_PARM feature was added; 2.1.30 is just a
> guess ...
This improvement seems nice. Without this change we could easily corrupt
the module by entering bad type or too long variables.
For strings, insmod stuff allocates memory. This probably explains why
the MIN-MAX parameters are not needed for strings.
Regards,
Gerard.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.rutgers.edu
