[3275] in linux-scsi channel archive
Re: Peeves about 2.1.85
daemon@ATHENA.MIT.EDU (Leonard N. Zubkoff)
Mon Feb 9 02:00:15 1998
Date: Sun, 8 Feb 1998 22:56:49 -0800
From: "Leonard N. Zubkoff" <lnz@dandelion.com>
To: eric@andante.jic.com
cc: Michael Lang <langa2@kph.uni-mainz.de>
CC: linux-scsi@vger.rutgers.edu
In-reply-to: <Pine.LNX.3.95.980208233202.23026O-100000@andante.jic.com>
(message from Eric Youngdale on Mon, 9 Feb 1998 00:34:09 -0500 (EST))
Date: Mon, 9 Feb 1998 00:34:09 -0500 (EST)
From: Eric Youngdale <eric@andante.jic.com>
Someone changed the initializer for IBMMCA in ibmmca.h back to the
old format, and I would bet large sums of money that the thing simply will
not compile. It has the wrong number of initializers as a number of new
elements were added to the structure. I am going to have to change it
back again - in the future I don't want to see the old style initializers
in any drivers because it means lots of edits whenever the structures are
changed. It is also extremely tedious to convert old initializers to the
new format (having done it 30+ times a few months back).
Ooops, this is probably partially my fault. I passed on an IBMMCA patch from
Michael Lang <langa2@kph.uni-mainz.de> and did not notice that the patch
changed the initializer back. Sorry about that.
I agree that the new style initializers are a much better approach; I've
changed all my code over to using it, even for 2.0.x.
Leonard
