[878] in linux-net channel archive
Re: Bad poetry about Firewalls and 1.3.17 (fwd)
daemon@ATHENA.MIT.EDU (Matti Aarnio)
Sat Aug 12 09:57:50 1995
From: Matti Aarnio <mea@utu.fi>
To: iialan@iifeak.swan.ac.uk (Alan Cox)
Date: Fri, 11 Aug 1995 13:23:16 +0300 (EET DST)
Cc: linux-net@vger.rutgers.edu, longyear@sii.com
In-Reply-To: <m0sgpsW-00013gC@iiit.swan.ac.uk> from "Alan Cox" at Aug 11, 95 09:55:44 am
[ I got this via Alan -- linux-net -list is rather slow to propagate.. ]
> From: Al Longyear <longyear@sii.com>
> To: "'Linux Networking List'" <linux-net@vger.rutgers.edu>
> Cc: "'Cox, Alan'" <iialan@iifeak.swan.ac.uk>
> Subject: Bad poetry about Firewalls and 1.3.17
> Date: Thu, 10 Aug 1995 13:02:27 -0700
>
> Please forgive my bad metric rhyme poetry about the recent 1.3.17 kernel.
>
> Try as I may, try as I might, I could not get firewalls to
> work last night.
>
> The problem comes from the recent change in that kernel which moved the
> firewall proc file system initialization logic to the firewall module.
> Unfortunately, no one bothered to call the firewall initialization
> procedure so the entries were not added to the proc file system.
Auch.. [hammering my head..]
> This resulted in the kernel panicking when I did a "list" function. It died
> in the lookup inode procedure of all of the strange places.
Yes, it dies, however it happens ONCE when looking up
something not existing in /proc/net/.
( Missing NULL-check on fs/proc/net.c )
"mea's culpa" that one too.. (Diff goes to Linus)
> I got it to work by putting the initialization call to ip_fw_init() in the
> ip_protocol_init function. However, that may not be the "best" place. I can
> only tell you of the problem and my solution. I leave it up to you fine
> ladies and gentlemen to find the "best" place for the initialization call
> to ip_fw_init.
I don't know any better place for it.
> --
> Al Longyear longyear@netcom.com
/Matti Aarnio <mea@utu.fi>
