[484] in linux-net channel archive
Tx timeout reloc. -- lance buglet.
daemon@ATHENA.MIT.EDU (Paul Gortmaker)
Wed Jun 14 05:43:30 1995
From: Paul Gortmaker <gpg109@rsphy1.anu.edu.au>
To: linux-net@vger.rutgers.edu
Date: Wed, 14 Jun 1995 17:59:12 +1000 (EST)
Cc: dplatt@3do.com
If you are using my Tx timeout relocation patch, there is a buglet
in the lance driver. Apparently I can't even follow my own instructions,
as I wrote:
------------------------
5) Just before exiting the tx function, set dev->tbusy according to whether
the card is ready to accept another packet or not. Something like:
dev->tbusy = tx_buffer_1_full && tx_buffer_2_full;
for a ping-pong driver is appropriate.
------------------------
but then forgot to add this:
--- /home/paul/lance.c.old Wed Jun 14 17:51:06 1995
+++ lance.c Wed Jun 14 16:35:33 1995
@@ -819,8 +819,10 @@
lp->lock = 0;
if (lp->tx_ring[(entry+1) & TX_RING_MOD_MASK].base == 0)
dev->tbusy=0;
- else
+ else {
lp->tx_full = 1;
+ dev->tbusy = 1;
+ }
restore_flags(flags);
return 0;
Oh well. There are probably others, seeing as there were in excess of 30
drivers to update. I will double check them all when I make sure it
all patches cleanly against 1.3.1 and stick it on rasty for anon. ftp.
Paul.
