[3518] in linux-net channel archive

home help back first fref pref prev next nref lref last post

Re: Very bad 2.0 bug: causes skb_push panic in tcp

daemon@ATHENA.MIT.EDU (Jon Lewis)
Thu Jun 27 12:19:58 1996

Date: 	Thu, 27 Jun 1996 11:31:57 -0400 (EDT)
From: Jon Lewis <jlewis@inorganic5.fdt.net>
To: Alan Cox <iialan@lusers.are.not.humans.org>
cc: linux-net@vger.rutgers.edu
In-Reply-To: <m0uZEJa-000QLBC@lusers.are.not.humans.org>

On Thu, 27 Jun 1996, Alan Cox wrote:

> 
> ip_send_room should have the skb_reserve(skb, MAX_HEADER) before the
> dev->hard_header test.

Do you mean this?

--- ip_output.c Thu Jun 27 11:30:25 1996
+++ ip_output.c.new     Thu Jun 27 11:28:35 1996
@@ -160,9 +160,9 @@
        skb->dev = dev;
        skb->arp = 1;
        skb->protocol = htons(ETH_P_IP);
+       skb_reserve(skb,MAX_HEADER);
        if (dev->hard_header)
        {
-               skb_reserve(skb,MAX_HEADER);
                if (rt && dev == rt->rt_dev && rt->rt_hh)
                {



------------------------------------------------------------------
 Jon Lewis                      |  Mime attachments are OK
 jlewis@inorganic5.fdt.net      |  But please ask before sending 
 http://inorganic5.fdt.net      |  unsolicited huge files.
________Finger jlewis@inorganic5.fdt.net for PGP public key_______


home help back first fref pref prev next nref lref last post