[1523] in linux-net channel archive

home help back first fref pref prev next nref lref last post

Multicast oops for 8390 cards

daemon@ATHENA.MIT.EDU (Paul Gortmaker)
Fri Dec 15 08:16:10 1995

From: Paul Gortmaker <gpg109@rsphy1.anu.edu.au>
To: iialan@www.linux.org.uk (Alan Cox)
Date: Fri, 15 Dec 1995 10:15:16 +1100 (EST)
Cc: torvalds@cs.helsinki.fi (Linus Torvalds), linux-net@vger.rutgers.edu


Hi Alan,

There is a remaining set of "#ifdef / #endif" that should have 
been removed in your 1.3.44 multicasting cleanup. 

This causes all 8390 cards to Oops upon a reset, because 
dev->set_multicast_list(dev) isn't assigned to any function.

[Wonder if vger will eat this one. Only one of my last 5 or so 
patches has actually made it through linux-net and back to me]

Regards,
Paul.

--- linux/drivers/net/8390.c.~	Fri Dec 15 09:41:30 1995
+++ linux/drivers/net/8390.c	Fri Dec 15 09:41:39 1995
@@ -612,9 +612,7 @@
     
     dev->hard_start_xmit = &ei_start_xmit;
     dev->get_stats	= get_stats;
-#ifdef HAVE_MULTICAST
     dev->set_multicast_list = &set_multicast_list;
-#endif
 
     ether_setup(dev);
         

home help back first fref pref prev next nref lref last post