[916] in Zephyr_Bugs

home help back first fref pref prev next nref lref last post

patch request

daemon@ATHENA.MIT.EDU (Chris Shabsin)
Tue Mar 24 14:55:27 1998

To: bug-zephyr@MIT.EDU
Reply-To: shabby@MIT.EDU
Date: Tue, 24 Mar 1998 14:55:25 EST
From: Chris Shabsin <shabby@tick.grey17.org>


So, in order to promote the use of the "display" field to contain more
information, I'd like to suggest the following patch to zwgc/zephyr.c:

*** zephyr.c	Tue Mar 24 14:38:12 1998
--- /mit/source/athena/lib/zephyr/zwgc/zephyr.c	Mon Sep 15 00:04:48 1997
***************
*** 146,153 ****
      if (dpy)
  	tty = DisplayString(dpy);
  #endif
-     if (getenv("ZLOCATION"))
-         tty = getenv("ZLOCATION");
      error_code = ZInitLocationInfo(NULL, tty);
      TRAP( error_code, "while initializing location information" );
  
--- 146,151 ----

As it currently stands, the display field is either set to a tty name
or an X display, and in many situations this information is completely
useless.  The tty name is almost universally useless, and the X
display can be useless if the client is running through an ssh tunnel.

People have been hacking around this limitation in zwgc for years now,
by setting the DISPLAY variable and using the -display or -ttymode
command line options, but now that hole has been closed.  So now, I
think the option should be made officially available.  

-----------
-Chris Shabsin                   -shabby@mit.edu
-Software Engineer, Dimensional Insight, Inc.

echo Prpv a\'rfg cnf har cvcr | tr Pacfghnrvp Cnpstuaeic

home help back first fref pref prev next nref lref last post