[117] in Zephyr_Bugs
zwgc code assumes unsigned chars
daemon@ATHENA.MIT.EDU (Ken Raeburn)
Mon Oct 22 05:50:55 1990
Date: Mon, 22 Oct 90 05:50:42 EDT
From: Ken Raeburn <Raeburn@MIT.Edu>
To: zephyr-bugs@ATHENA.MIT.EDU
A lot of array indexing is done with character values. The characters
(or the target of the pointer) should be made "unsigned char".
The character_class objects in formatter.c should be either "const" or
initialized at runtime.
If character_class were defined as
struct { char x[NUMBER_OF_CHARACTERS]; }
then character_class.c could be made cleaner, though there'd be some
cost in efficiency when character_class objects are passed as
arguments (which could be dealt with by making some of the addressing
explicit, rather than hidden in the fact that this type is currently
an array).
When we get a real ANSI C environment, NUMBER_OF_CHARACTERS should be
replaced with UCHAR_MAX (from <limits.h>).
