[2875] in Release_Engineering
motdfile and motd2file changes...
daemon@ATHENA.MIT.EDU (vanharen@MIT.EDU)
Thu Jun 11 10:52:30 1992
From: vanharen@MIT.EDU
Date: Thu, 11 Jun 92 10:52:14 EDT
To: rel-eng@MIT.EDU
Cc: mar@MIT.EDU
In-Reply-To: [2853] in rel-eng
I just caught up in rel-eng... when I got to transaction 2853, I
noticed that the patch that Mark submitted for xlogin.c to do the second
motfile removed the "#ifdef notdef" lines around the motdfile
command-line switch and resource.
The reason that I had them ifdef'ed out was to prevent hacking. Having
a hardcoded path in the binary makes it a little more difficult to hack
the motd on a given machine. Sure, it is still possible, in a number of
ways, but at least it is not trivial. This change makes it so. I would
suggest considering changing this code.
Of course, having motd2file as a command-line switch or resource makes
hacking trivial as well -- I am not sure what can be done about that,
though. Perhaps it could be a hardcoded path as well, and have that
file added to the list of files to be cleaned if the workstation is
public.
If someone wants me to, I'll make the change, since Mark is out this
week. Please let me know what you decide, one way or the other.
-C.
