[2870] in Release_Engineering
fixes for olh...
daemon@ATHENA.MIT.EDU (vanharen@MIT.EDU)
Wed Jun 10 17:11:24 1992
From: vanharen@MIT.EDU
Date: Wed, 10 Jun 92 17:11:07 EDT
To: rel-eng@MIT.EDU
The following patch fixes 2 things...
1) When the printer dialog is up, the delete key did not work properly.
The MuSetEmacsBindings line fixes that, although I have not gotten it to
work correctly on a sun -- the Delete key works, but BackSpace does not.
It should, but this is not a major setback as there are very few suns
yet.
2) The arrow keys now work to navigate the olh tree. The 7.3 release
allowed this (undocumented feature), but it broke in the 7.4 release
unless you clicked inside the list widget first. I had not noticed this
before a few days ago. I doubt many other people would've noticed
either, as it is undocumented (I think).
-C.
==============================================================================
diff -rbwc /source/athena/athena.bin/olh/motif/visual.c ./visual.c
*** /source/athena/athena.bin/olh/motif/visual.c Fri May 1 17:10:24 1992
--- ./visual.c Wed Jun 10 16:35:36 1992
***************
*** 94,101 ****
add_help_menus();
! w[MAIN] = XtCreateManagedWidget("main", xmFormWidgetClass,
w[TOPLEVEL], NULL, 0);
(void) XtCreateManagedWidget("banner", xmLabelGadgetClass,
w[MAIN], NULL, 0);
--- 94,102 ----
add_help_menus();
! W = w[MAIN] = XtCreateManagedWidget("main", xmFormWidgetClass,
w[TOPLEVEL], NULL, 0);
+ XtAddRawEventHandler(W, KeyPressMask, FALSE, ListExtra, MENU_LIST);
(void) XtCreateManagedWidget("banner", xmLabelGadgetClass,
w[MAIN], NULL, 0);
***************
*** 104,109 ****
--- 105,111 ----
W = w[MENU_BAR] = MuCreateMenuBar( w[MAIN], "menubar", NULL, 0);
XtManageChild(W);
+ XtAddRawEventHandler(W, KeyPressMask, FALSE, ListExtra, MENU_LIST);
/* Fix menu button for External viewers so that it is correct given the */
/* default.*/
***************
*** 174,179 ****
--- 176,182 ----
xmPushButtonWidgetClass,
w[MAIN], NULL, 0);
XtAddCallback(W, XmNactivateCallback, ButtonCB, QUIT_BTN);
+ XtAddRawEventHandler(W, KeyPressMask, FALSE, ListExtra, MENU_LIST);
(void) XtCreateManagedWidget("messageSep", xmSeparatorGadgetClass,
w[MAIN], NULL, 0);
***************
*** 216,221 ****
--- 219,225 ----
W = w[MENU_OPT] = XmCreateRowColumn(w[MENU_FORM], "menuName",
args, 2);
XtManageChild(W);
+ XtAddRawEventHandler(W, KeyPressMask, FALSE, ListExtra, MENU_LIST);
/* Buttons */
***************
*** 223,243 ****
--- 227,251 ----
xmPushButtonWidgetClass,
w[MENU_FORM], NULL, 0);
XtAddCallback(W, XmNactivateCallback, ButtonCB, PREV_BTN);
+ XtAddRawEventHandler(W, KeyPressMask, FALSE, ListExtra, MENU_LIST);
W = w[VIEW_BTN] = XtCreateManagedWidget("view",
xmPushButtonWidgetClass,
w[MENU_FORM], NULL, 0);
XtAddCallback(W, XmNactivateCallback, ButtonCB, VIEW_BTN);
+ XtAddRawEventHandler(W, KeyPressMask, FALSE, ListExtra, MENU_LIST);
W = w[NEXT_BTN] = XtCreateManagedWidget("next",
xmPushButtonWidgetClass,
w[MENU_FORM], NULL, 0);
XtAddCallback(W, XmNactivateCallback, ButtonCB, NEXT_BTN);
+ XtAddRawEventHandler(W, KeyPressMask, FALSE, ListExtra, MENU_LIST);
W = w[UP_BTN] = XtCreateManagedWidget("up",
xmPushButtonWidgetClass,
w[MENU_FORM], NULL, 0);
XtAddCallback(W, XmNactivateCallback, ButtonCB, UP_BTN);
+ XtAddRawEventHandler(W, KeyPressMask, FALSE, ListExtra, MENU_LIST);
/* List widget */
***************
*** 624,629 ****
--- 632,638 ----
XtAddCallback(W, XmNokCallback, File_ok, PRINT_DLG);
XtDestroyWidget(XmSelectionBoxGetChild(W, XmDIALOG_HELP_BUTTON));
d_made[N_PRINT_DLG] = 1;
+ MuSetEmacsBindings(XmSelectionBoxGetChild(W, XmDIALOG_TEXT));
break;
default:
