[2849] in Release_Engineering

home help back first fref pref prev next nref lref last post

dash/console fix...

daemon@ATHENA.MIT.EDU (vanharen@MIT.EDU)
Sat May 30 13:17:43 1992

From: vanharen@MIT.EDU
Date: Sat, 30 May 92 13:17:33 EDT
To: rel-eng@MIT.EDU


Minor fix, if you are willing to pick it up.  If not, no big deal, it
can wait.

This is purely a cosmetic fix, to work around a decstation X server bug.
That server does not join rectangles correctly.  This can be seen in
several places -- for an example, look at the console program on a
decstation.  Move the mouse into the "hide" button, so that the
highlighting rectangle appears.  Note how the upper-left-hand pixel in
the rectangle is not drawn.  This is a bug in the server -- it is not
doing the join correctly.  I will submit a seperate bug-report for that,
to "bugs", as this is not related to this release specifically, it
existed in the last release as well.

At any rate, the diffs are below.
						-C.

==============================================================================
*** Button.c	Sat May 30 11:46:20 1992
--- /source/athena/athena.bin/dash/Button.c	Fri May  1 19:47:41 1992
***************
*** 113,121 ****
    values.background = me->button.background;
    values.line_width = me->button.borderThickness;
    values.graphics_exposures = False;
-   values.cap_style = CapProjecting;
    valuemask = ( GCForeground | GCBackground | GCLineWidth
! 	       | GCFunction | GCGraphicsExposures | GCCapStyle );
  
    me->button.foreground_gc = XjCreateGC(me->core.display,
  					me->core.window,
--- 113,120 ----
    values.background = me->button.background;
    values.line_width = me->button.borderThickness;
    values.graphics_exposures = False;
    valuemask = ( GCForeground | GCBackground | GCLineWidth
! 	       | GCFunction | GCGraphicsExposures );
  
    me->button.foreground_gc = XjCreateGC(me->core.display,
  					me->core.window,

home help back first fref pref prev next nref lref last post