[2815] in Release_Engineering
audit of Richard Basch's changes to login
daemon@ATHENA.MIT.EDU (Bill Cattey)
Thu May 7 19:27:11 1992
Date: Thu, 7 May 1992 19:26:51 -0400 (EDT)
From: Bill Cattey <wdc@Athena.MIT.EDU>
To: rel-eng@Athena.MIT.EDU
I have finished going over the changes to login submitted by Richard.
I find them sane. I looked at all the code, and the changes, but did
not do the total "Anally Retentive Chef" routine of tracking down all
the called procedures and checking all the arguments. Nor did I do any
more than a basic read/compare of common code blocks such as those
repeated in verify.c and athena.c.
If problems do occur with this code, I am now qualified to help debug it.
Here are my notes on my audit; you may classify all the mentioned files
as audited:
/source/Aix-3.1/tsm/setpenv.c -- goto home uses athena_home.
Purge kauth stuff.
/source/Aix-3.1/tsm/tsm.c -- hook for afsok use of tsm.
/source/Aix-3.1/tsm/tsmlogin.c -- Hard wire AFSTSM false
tsmloginsetup sets proper tty name (needs comment)
did utmp handling bug fixes for reactivate.
/source/Aix-3.1/tsm/athena.c
/source/Aix-3.1/tsm/athena.h
/source/athena/athena.etc/cleanup/cleanup.c
/source/athena/athena.lib/kerberos/appl/bsd/login.c
port to RS/6000; add setpag.
seems sane; remains unhesiodized.
/source/athena/athena.lib/kerberos/appl/bsd/Imakefile
/source/athena/athena.etc/xdm/xlogin/verify.c
does no unlog because the x session does it.
dm.h contains verify structure definition
dologin takes verify if XDM defined
why is USENVIRON, SYSENVIRON now conditional on !XDM?
dologin: ifdef XDM (near end)
script and session transposed because our xdm
and X consortium xdm give them different meanings.
add_to_passwd:
remove_from_passwd:
add_to_group: seems mostly sane. (same as in athena.c)
/source/athena/athena.etc/xdm/xlogin/Imakefile
Xlogin.aix.presed vs Xlogin.rios.presed
/source/athena/athena.etc/xdm/dm/dm.c
TODO fsid -u -f fsname in athena.c: user_cleanup -- requires
a static flag if anything attached. Leave it alone...
-wdc
