[30632] in Kerberos
Re: krb5_sendauth vs NAGLE vs DelayedAck
daemon@ATHENA.MIT.EDU (John Hascall)
Thu Jan 15 15:50:49 2009
To: Ken Raeburn <raeburn@MIT.EDU>
In-reply-to: Your message of Thu, 15 Jan 2009 14:20:02 -0500.
<6A7C6331-CEBB-4EE5-9A83-7DC18C92093A@MIT.EDU>
Date: Thu, 15 Jan 2009 14:49:31 CST
Message-ID: <1798.1232052571@malison.ait.iastate.edu>
From: John Hascall <john@iastate.edu>
Cc: kerberos@MIT.EDU
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: kerberos-bounces@MIT.EDU
> On Jan 15, 2009, at 09:41, John Hascall wrote:
> > I think you might want to also change krb5_sendauth() to
> > call krb5int_net_writev() directly (or yet another helper
> > function!) since krb5_sendauth() will still be doing two
> > consecutive writes where it does the two version strings:
> Yeah, I missed that, thanks. I've just checked in another fix.
Great.
> There are also multiple calls possible in recvauth but it's not
> unconditionally doing two successive writes, so some rearranging of
> code would be needed there; the hardest bit would probably be making
> sure multiple paths through the code get tested. If you feel like
> tackling it, that'd be great, but I'm going to get back to my current
> project for a bit.
The only place I could see where a double-write could happen
was a successful mutual auth. So, here's my attempt at a
minimal rewrite to handle that:
http://john.public.iastate.edu/recvauth.c
(basically I just made outbuf into a array[2] and some
logic around calling krb5int_write_messages() with
1 or 2 entries from it).
John
________________________________________________
Kerberos mailing list Kerberos@mit.edu
https://mailman.mit.edu/mailman/listinfo/kerberos
