[30628] in Kerberos

home help back first fref pref prev next nref lref last post

Re: krb5_sendauth vs NAGLE vs DelayedAck

daemon@ATHENA.MIT.EDU (John Hascall)
Thu Jan 15 09:42:27 2009

To: Ken Raeburn <raeburn@mit.edu>
In-reply-to: Your message of Wed, 14 Jan 2009 20:06:58 -0500.
	<B08751F2-38C9-4038-88FA-A0792B159613@mit.edu> 
Date: Thu, 15 Jan 2009 08:41:09 CST
Message-ID: <894.1232030469@malison.ait.iastate.edu>
From: John Hascall <john@iastate.edu>
Cc: kerberos@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: kerberos-bounces@mit.edu


> I think this is fixed in the sources now, with revision 21749.  If you  
> want to try out my change, you can get the changes from
>   http://src.mit.edu/fisheye/changelog/krb5/?cs=21749 
>   ... um, when the fisheye server starts updating again.  Or off the  
> anonsvn server.
> Ken

Ken,

I think you might want to also change krb5_sendauth() to
call krb5int_net_writev() directly (or yet another helper
function!) since krb5_sendauth() will still be doing two
consecutive writes where it does the two version strings:

        outbuf.length = strlen(sendauth_version) + 1;
        outbuf.data = (char *) sendauth_version;
        if ((retval = krb5_write_message(context, fd, &outbuf)))
                return(retval);

        outbuf.length = strlen(appl_version) + 1;
        outbuf.data = appl_version;
        if ((retval = krb5_write_message(context, fd, &outbuf)))
                return(retval);



John
________________________________________________
Kerberos mailing list           Kerberos@mit.edu
https://mailman.mit.edu/mailman/listinfo/kerberos

home help back first fref pref prev next nref lref last post