[5491] in Moira
Re: Bug in shared library builds
daemon@ATHENA.MIT.EDU (Garry P Zacheiss)
Mon Oct 19 12:39:23 2009
From: Garry P Zacheiss <zacheiss@MIT.EDU>
To: "broder@mit.edu" <broder@mit.edu>
CC: "moiradev@mit.edu" <moiradev@mit.edu>
Date: Mon, 19 Oct 2009 12:39:13 -0400
Message-ID: <04F36375-E4CC-44C4-9913-318ACD5BAF37@mit.edu>
In-Reply-To: <4ADB8E32.9080603@mit.edu>
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sure, checked in.
Next time, can you make sure the patch isn't full of Control-M line
endings?
Thanks,
Garry
On Oct 18, 2009, at 5:52 PM, Evan Broder wrote:
> Hi -
> I think I've found a bug in the new shared library build process.
> Currently configure.in sets
>
> LIBS="-lmoira $KLIBS"
>
> on line 467.
>
> This seems to cause the linker to prefer a globally installed libmoira
> over the one in the build tree. Since it is linking a shared library
> and
> not a static one, this generally works out, but you'll run into
> problems
> if you add new symbols to libmoira. I think instead you want to link
> against the libmoira.la file directly, which is defined just below in
> MR_LIBDEP.
>
> I believe the attached patch will fix the issue.
>
> - Evan
> <use-build-tree-libmoira.patch>
