[13] in Moira

home help back first fref pref prev next nref lref last post

No subject found in mail header

daemon@ATHENA.MIT.EDU (probe@ATHENA.MIT.EDU)
Tue Jan 2 08:59:22 1990

From: probe@ATHENA.MIT.EDU
Date: Tue, 2 Jan 90 06:03:16 -0500
To: bug-moira@ATHENA.MIT.EDU
This seems to be an old bug report that was recently re-reported... I am
sending this to you so that in case you hadn't received it already.

-Richard

/***** paris:changes / garner /  1:18 am  Sep 12, 1989*/
From garner@ATHENA.MIT.EDU  Tue Sep 12 01:18:20 1989
From: <garner@ATHENA.MIT.EDU>
Date: Tue, 12 Sep 89 01:18:10 -0400
To: changes@ATHENA.MIT.EDU
Subject: patch: (RTPC) Version 6.3B: chfn

Date: Wed, 6 Sep 89 16:40:49 -0400
From: Jonathan I. Kamens <jik@ATHENA.MIT.EDU>
Sender: jik@ATHENA.MIT.EDU
To: bugs@ATHENA.MIT.EDU
Subject: (RTPC) Version 6.3B: chfn

System type, version:	(RTPC) Version 6.3B
System name:		vulcan
What's wrong:

  The procedure "ask" in ~source/third_party/sms/clients/passwd/chfn.c
is supposed to allow "none" as a valid response for any field, but it
is broken and therefore doesn't allow "none" for phone number fields.
The patch below will fix this problem.

*** chfn.c.orig	Wed Sep  6 14:03:52 1989
--- chfn.c	Wed Sep  6 14:04:22 1989
***************
*** 258,265 ****
  	buf[strlen(buf) - 1] = NULL;
  	if (strlen(buf) == 0)
  	    result = def_val;
! 	else if (strcasecmp(buf, BLANK) == NULL)
  	    result = "";
  	else 
  	    result = buf;
  	
--- 258,267 ----
  	buf[strlen(buf) - 1] = NULL;
  	if (strlen(buf) == 0)
  	    result = def_val;
! 	else if (strcasecmp(buf, BLANK) == NULL) {
  	    result = "";
+ 	    goto done;
+         }
  	else 
  	    result = buf;
  	
***************
*** 304,310 ****
      }
      
      /* Remove dashes if necessary */
!     if (dashes && result == buf) {
  	char *tmp1, *tmp2;
  	tmp1 = tmp2 = (char *)buf;
  	do {
--- 306,312 ----
      }
      
      /* Remove dashes if necessary */
!     if (dashes) {
  	char *tmp1, *tmp2;
  	tmp1 = tmp2 = (char *)buf;
  	do {
***************
*** 313,319 ****
  	}
  	while (*(tmp1++));
      }
!     
      return(result);
  }
  	
--- 315,322 ----
  	}
  	while (*(tmp1++));
      }
! 
! done:
      return(result);
  }
  	
/* ---------- */

home help back first fref pref prev next nref lref last post