[30404] in CVS-changelog-for-Kerberos-V5
krb5 commit [krb5-1.16]: Fix double-close in ksu
daemon@ATHENA.MIT.EDU (Greg Hudson)
Mon Jan 7 01:57:57 2019
Date: Mon, 7 Jan 2019 01:57:52 -0500
From: Greg Hudson <ghudson@mit.edu>
Message-ID: <201901070657.x076vqYn016183@drugstore.mit.edu>
To: <cvs-krb5@mit.edu>
MIME-Version: 1.0
Reply-To: krbdev@mit.edu
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/57378fb169444ee224ebc1b5d406f1b9ce562b11
commit 57378fb169444ee224ebc1b5d406f1b9ce562b11
Author: Robbie Harwood <rharwood@redhat.com>
Date: Tue Dec 18 15:18:13 2018 -0500
Fix double-close in ksu get_authorized_princ_names
If list_union() fails due to an allocation failure, then close_time()
will attempt to fclose users_fp and login_fp a second time.
This bug was originally introduced in commit
be95b52c2d0c21b1fe92f9f90166fc2fa8eecc95, and has been present in
every krb5 release since 1.1.
(cherry picked from commit 0b8c6f3e1e8e561aa56a7d4e2171320119991dae)
ticket: 8768
version_fixed: 1.16.3
src/clients/ksu/heuristic.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/src/clients/ksu/heuristic.c b/src/clients/ksu/heuristic.c
index 0d055e4..3eb28ab 100644
--- a/src/clients/ksu/heuristic.c
+++ b/src/clients/ksu/heuristic.c
@@ -266,7 +266,6 @@ get_authorized_princ_names(luser, cmd, princ_list)
retval = list_union(k5login_list, k5users_filt_list, &combined_list);
if (retval){
- close_time(k5users_flag,users_fp, k5login_flag,login_fp);
return retval;
}
*princ_list = combined_list;
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
