[30325] in CVS-changelog-for-Kerberos-V5
krb5 commit: Fix minor leak in kadmind password change dispatch
daemon@ATHENA.MIT.EDU (Greg Hudson)
Fri Oct 26 10:42:19 2018
Date: Fri, 26 Oct 2018 10:42:08 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201810261442.w9QEg8hI025913@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/597f18953367bbc246fbb0222355a7a94ffff6b4
commit 597f18953367bbc246fbb0222355a7a94ffff6b4
Author: Greg Hudson <ghudson@mit.edu>
Date: Thu Oct 25 12:21:45 2018 -0400
Fix minor leak in kadmind password change dispatch
In the unlikely event that kadmind cannot resolve the KDB keytab in
schpw.c:dispatch(), don't leak the error message. Reported by Bean
Zhang.
src/kadmin/server/schpw.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/src/kadmin/server/schpw.c b/src/kadmin/server/schpw.c
index 491cba9..f7dea39 100644
--- a/src/kadmin/server/schpw.c
+++ b/src/kadmin/server/schpw.c
@@ -438,11 +438,14 @@ dispatch(void *handle, const krb5_fulladdr *local_addr,
krb5_keytab kt = NULL;
kadm5_server_handle_t server_handle = (kadm5_server_handle_t)handle;
krb5_data *response = NULL;
+ const char *emsg;
ret = krb5_kt_resolve(server_handle->context, "KDB:", &kt);
if (ret != 0) {
+ emsg = krb5_get_error_message(server_handle->context, ret);
krb5_klog_syslog(LOG_ERR, _("chpw: Couldn't open admin keytab %s"),
- krb5_get_error_message(server_handle->context, ret));
+ emsg);
+ krb5_free_error_message(server_handle->context, emsg);
goto egress;
}
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
