[30245] in CVS-changelog-for-Kerberos-V5

home help back first fref pref prev next nref lref last post

krb5 commit: Don't leak work queue items in gss-server

daemon@ATHENA.MIT.EDU (Greg Hudson)
Tue Jun 26 12:14:32 2018

Date: Tue, 26 Jun 2018 12:14:24 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201806261614.w5QGEOwn031897@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu

https://github.com/krb5/krb5/commit/db479eb8d76e04ad3227263dd01e80d300c3fd9f
commit db479eb8d76e04ad3227263dd01e80d300c3fd9f
Author: Robbie Harwood <rharwood@redhat.com>
Date:   Tue Jun 19 11:32:44 2018 -0400

    Don't leak work queue items in gss-server
    
    On accept() failure in gss-server.c, we would leak the freshly
    allocated work item.

 src/appl/gss-sample/gss-server.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/appl/gss-sample/gss-server.c b/src/appl/gss-sample/gss-server.c
index c0d0da3..6b5959a 100644
--- a/src/appl/gss-sample/gss-server.c
+++ b/src/appl/gss-sample/gss-server.c
@@ -781,6 +781,7 @@ main(int argc, char **argv)
                 /* Accept a TCP connection */
                 if ((work->s = accept(stmp, NULL, 0)) < 0) {
                     perror("accepting connection");
+                    free(work);
                     continue;
                 }
 
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5

home help back first fref pref prev next nref lref last post