[30134] in CVS-changelog-for-Kerberos-V5

home help back first fref pref prev next nref lref last post

krb5 commit: Remove unneeded conditional in hex.c

daemon@ATHENA.MIT.EDU (Greg Hudson)
Mon Mar 19 20:54:21 2018

Date: Mon, 19 Mar 2018 20:54:14 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201803200054.w2K0sER9018741@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu

https://github.com/krb5/krb5/commit/a9f9a68d21f8f06dd78b80208aee292d2266a85d
commit a9f9a68d21f8f06dd78b80208aee292d2266a85d
Author: Greg Hudson <ghudson@mit.edu>
Date:   Mon Mar 19 12:23:19 2018 -0400

    Remove unneeded conditional in hex.c
    
    hex_digit() accepts bval as an unsigned parameter, so we don't need to
    test if bval >= 0.

 src/util/support/hex.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/util/support/hex.c b/src/util/support/hex.c
index 4407ff9..cbd30d7 100644
--- a/src/util/support/hex.c
+++ b/src/util/support/hex.c
@@ -37,7 +37,7 @@
 static inline char
 hex_digit(uint8_t bval, int uppercase)
 {
-    assert(bval >= 0 && bval <= 0xF);
+    assert(bval <= 0xF);
     if (bval < 10)
         return '0' + bval;
     else if (uppercase)
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5

home help back first fref pref prev next nref lref last post