[30108] in CVS-changelog-for-Kerberos-V5

home help back first fref pref prev next nref lref last post

krb5 commit: Fix memory leak in test authdata server

daemon@ATHENA.MIT.EDU (Greg Hudson)
Fri Feb 23 15:21:12 2018

Date: Fri, 23 Feb 2018 15:21:04 -0500
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201802232021.w1NKL4sA024996@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu

https://github.com/krb5/krb5/commit/d047fb82738a7c45e71aa5e532621e46d02fa13b
commit d047fb82738a7c45e71aa5e532621e46d02fa13b
Author: sashan <anedvedicky@gmail.com>
Date:   Tue Feb 20 22:41:28 2018 +0100

    Fix memory leak in test authdata server
    
    greet_kdc_sign() must always free if_relevant.

 src/plugins/authdata/greet_server/greet_auth.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/src/plugins/authdata/greet_server/greet_auth.c b/src/plugins/authdata/greet_server/greet_auth.c
index 1f1e9de..7ef8f66 100644
--- a/src/plugins/authdata/greet_server/greet_auth.c
+++ b/src/plugins/authdata/greet_server/greet_auth.c
@@ -83,10 +83,9 @@ greet_kdc_sign(krb5_context context,
     if (code == 0) {
         krb5_free_authdata(context, enc_tkt_reply->authorization_data);
         enc_tkt_reply->authorization_data = tkt_authdata;
-    } else {
-        krb5_free_authdata(context, if_relevant);
     }
 
+    krb5_free_authdata(context, if_relevant);
     krb5_free_authdata(context, kdc_issued);
 
     return code;
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5

home help back first fref pref prev next nref lref last post