[29753] in CVS-changelog-for-Kerberos-V5
krb5 commit [krb5-1.15]: Fix rare leak in krb5_cccol_have_content()
daemon@ATHENA.MIT.EDU (Tom Yu)
Mon Oct 24 17:07:17 2016
Date: Mon, 24 Oct 2016 17:07:12 -0400
From: Tom Yu <tlyu@mit.edu>
Message-Id: <201610242107.u9OL7CgX011583@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/3bb6e66c07a9864cc7ece0604105bd987e1d2977
commit 3bb6e66c07a9864cc7ece0604105bd987e1d2977
Author: Greg Hudson <ghudson@mit.edu>
Date: Fri Oct 21 02:06:18 2016 -0400
Fix rare leak in krb5_cccol_have_content()
If krb5_cc_start_seq_get() fails inside the loop, close the current
credential cache before continuing to the next one. Reported by Todd
Lipcon.
(cherry picked from commit 1735f2e74767e56ac3bd75de61d41b8363ec6ce4)
ticket: 8509
version_fixed: 1.15
src/lib/krb5/ccache/cccursor.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/src/lib/krb5/ccache/cccursor.c b/src/lib/krb5/ccache/cccursor.c
index 281f128..c31a3f5 100644
--- a/src/lib/krb5/ccache/cccursor.c
+++ b/src/lib/krb5/ccache/cccursor.c
@@ -255,8 +255,10 @@ krb5_cccol_have_content(krb5_context context)
ret = krb5_cc_start_seq_get(context, cache, &cache_cursor);
save_first_error(context, ret, &errsave);
- if (ret)
+ if (ret) {
+ krb5_cc_close(context, cache);
continue;
+ }
while (!found) {
ret = krb5_cc_next_cred(context, cache, &cache_cursor, &creds);
save_first_error(context, ret, &errsave);
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
