[29612] in CVS-changelog-for-Kerberos-V5
krb5 commit [krb5-1.14]: Fix krb5_get_init_creds_password() pwchange
daemon@ATHENA.MIT.EDU (Tom Yu)
Fri Sep 2 17:07:26 2016
Date: Fri, 2 Sep 2016 17:04:23 -0400
From: Tom Yu <tlyu@mit.edu>
Message-Id: <201609022104.u82L4Nsu023664@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/9f1a91e5a75727a89a1e9aeb41fc612e19af5241
commit 9f1a91e5a75727a89a1e9aeb41fc612e19af5241
Author: Greg Hudson <ghudson@mit.edu>
Date: Tue Jun 28 14:52:31 2016 -0400
Fix krb5_get_init_creds_password() pwchange leak
When krb5_get_init_creds_password() attempts to change the password,
make sure to free code_string along all exit paths.
(cherry picked from commit 3e5f7709e1928f1e814c427f2811d9204a167439)
ticket: 8440
version_fixed: 1.14.4
src/lib/krb5/krb/gic_pwd.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/lib/krb5/krb/gic_pwd.c b/src/lib/krb5/krb/gic_pwd.c
index e95673f..298f075 100644
--- a/src/lib/krb5/krb/gic_pwd.c
+++ b/src/lib/krb5/krb/gic_pwd.c
@@ -443,6 +443,7 @@ krb5_get_init_creds_password(krb5_context context,
/* the change succeeded. go on */
if (result_code == 0) {
+ free(code_string.data);
free(result_string.data);
break;
}
@@ -452,6 +453,7 @@ krb5_get_init_creds_password(krb5_context context,
ret = KRB5_CHPW_FAIL;
if (result_code != KRB5_KPASSWD_SOFTERROR) {
+ free(code_string.data);
free(result_string.data);
goto cleanup;
}
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
