[29589] in CVS-changelog-for-Kerberos-V5
krb5 commit: Fix leak in krb5_server_decrypt_ticket_keytab()
daemon@ATHENA.MIT.EDU (Greg Hudson)
Thu Aug 25 10:42:02 2016
Date: Thu, 25 Aug 2016 10:41:58 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201608251441.u7PEfwx0018544@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/9984c2343c96f3aaaf8a8d6dfc1b6de1eae533c2
commit 9984c2343c96f3aaaf8a8d6dfc1b6de1eae533c2
Author: Seemant Choudhary <seemant@soha.io>
Date: Wed Aug 24 12:20:01 2016 -0400
Fix leak in krb5_server_decrypt_ticket_keytab()
When we skip a keytab entry because it is of the wrong enctype, free
it before continuing.
ticket: 8482
target_version: 1.14-next
target_version: 1.13-next
tags: pullup
src/lib/krb5/krb/srv_dec_tkt.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/src/lib/krb5/krb/srv_dec_tkt.c b/src/lib/krb5/krb/srv_dec_tkt.c
index 708a25f..6c92252 100644
--- a/src/lib/krb5/krb/srv_dec_tkt.c
+++ b/src/lib/krb5/krb/srv_dec_tkt.c
@@ -99,8 +99,10 @@ krb5_server_decrypt_ticket_keytab(krb5_context context,
retval = KRB5_KT_NOTFOUND;
while ((code = krb5_kt_next_entry(context, keytab,
&ktent, &cursor)) == 0) {
- if (ktent.key.enctype != ticket->enc_part.enctype)
+ if (ktent.key.enctype != ticket->enc_part.enctype) {
+ (void) krb5_free_keytab_entry_contents(context, &ktent);
continue;
+ }
retval = decrypt_ticket_keyblock(context, &ktent.key, ticket);
if (retval == 0) {
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
