[29449] in CVS-changelog-for-Kerberos-V5
krb5 commit: Fix recent memory leak in locate_kdc.c
daemon@ATHENA.MIT.EDU (Greg Hudson)
Wed Jun 29 13:26:51 2016
Date: Wed, 29 Jun 2016 13:26:46 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201606291726.u5THQkB4012322@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/ebb59a92cc831dfef73dc41f8be6ccee68359300
commit ebb59a92cc831dfef73dc41f8be6ccee68359300
Author: Greg Hudson <ghudson@mit.edu>
Date: Tue Jun 21 18:46:28 2016 -0400
Fix recent memory leak in locate_kdc.c
Commit ce112dec844e4650b5ad174bd40f21c32aebe1d1 introduced a memory
leak in locate_srv_conf_1() by moving the free(realmstr) call to the
cleanup handler, because there was an early return after realmstr is
allocated. Convert that early return to a goto.
src/lib/krb5/os/locate_kdc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/lib/krb5/os/locate_kdc.c b/src/lib/krb5/os/locate_kdc.c
index cd48627..6d4416c 100644
--- a/src/lib/krb5/os/locate_kdc.c
+++ b/src/lib/krb5/os/locate_kdc.c
@@ -240,7 +240,7 @@ locate_srv_conf_1(krb5_context context, const krb5_data *realm,
error_message(code));
if (code == PROF_NO_SECTION || code == PROF_NO_RELATION)
code = 0;
- return code;
+ goto cleanup;
}
for (i=0; hostlist[i]; i++) {
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
