[28981] in CVS-changelog-for-Kerberos-V5
krb5 commit: Fix kdcpreauth counting bug
daemon@ATHENA.MIT.EDU (Greg Hudson)
Thu Jul 9 14:44:32 2015
Date: Thu, 9 Jul 2015 14:44:26 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201507091844.t69IiQjE006187@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/2c3c44ce0555110a919aff0902d143b7f00e26ef
commit 2c3c44ce0555110a919aff0902d143b7f00e26ef
Author: Greg Hudson <ghudson@mit.edu>
Date: Thu Jul 9 01:00:40 2015 -0400
Fix kdcpreauth counting bug
In kdc_preauth.c, commit be20a5f5cee8d6c4072d1b81712520dbf9f6eefd made
load_preauth_plugins() handle negative preauth type numbers.
get_plugin_vtables() also needs to handle negative preauth type
numbers, or it can return the wrong count and load_preauth_plugins()
can overflow the table.
ticket: 8200
src/kdc/kdc_preauth.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/kdc/kdc_preauth.c b/src/kdc/kdc_preauth.c
index 34775f3..e121c5d 100644
--- a/src/kdc/kdc_preauth.c
+++ b/src/kdc/kdc_preauth.c
@@ -235,7 +235,7 @@ get_plugin_vtables(krb5_context context,
n_tables++;
}
for (i = 0, n_systems = 0; i < n_tables; i++) {
- for (count = 0; vtables[i].pa_type_list[count] > 0; count++);
+ for (count = 0; vtables[i].pa_type_list[count] != 0; count++);
n_systems += count;
}
*vtables_out = vtables;
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
